review-checklist: show non-CODEOWNER reviewer when no area owner is assigned#6446
Merged
brtnfld merged 2 commits intoJun 12, 2026
Merged
Conversation
If the only assigned CODEOWNER is removed and a non-CODEOWNER is manually added in their place, that person previously got no checklist mention and their approval did not check the box. For any area with no CODEOWNER in the requested set, fall back to non-CODEOWNER reviewers (anyone assigned who is not an owner of any touched area). They are shown in the mention and their approval counts as sign-off for that area.
brtnfld
requested review from
glennsong09,
hyoklee,
jhendersonHDF and
lrknox
as code owners
Contributor
Review ChecklistThis PR touches the following areas. Each needs at least one
|
Adding or removing a reviewer did not trigger a workflow run, leaving the checklist comment stale until the next push. Add review_requested and review_request_removed to the pull_request_target activity types so the checklist updates immediately when a reviewer is manually added or removed.
jhendersonHDF
approved these changes
Jun 12, 2026
github-project-automation
Bot
moved this from To be triaged
to Done
in HDF5 - TRIAGE & TRACK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@mentionappears in the checklist row and their approval counts as sign-off for that area